[PATCH] D86065: [SVE] Make ElementCount members private
Paul Walker via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 27 04:44:58 PDT 2020
paulwalker-arm added a comment.
I cannot say whether such questions make sense without a deeper investigation, but I can say for certain that EC.isPowerOf2 is a question we cannot answer at compile time. Given this is a mechanical change I would just remove the member function and leave the code as is (well change EC.Min to EC.getKnownMinValue()). We already know that we'll need to visit the places where getKnownMinValue() is used to ensure the question makes sense in the face of scalable vectors.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86065/new/
https://reviews.llvm.org/D86065
More information about the llvm-commits
mailing list