[PATCH] D86065: [SVE] Make ElementCount members private

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: llvm/include/llvm/Support/TypeSize.h:108
+
+  bool isPowerOf2() const { return isPowerOf2_32(Min); }
 };
----------------
I don't believe this is safe.  For example we know SVE supported vector lengths only have to be a multiple of 128bits.  So for scalable vectors we cannot know the element count is a power of 2 unless we perform a runtime check.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86065/new/

https://reviews.llvm.org/D86065