[PATCH] D86249: [llvm][sve] Make `llvm.masked.[gather|scatter]` legal for SVE.
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 27 03:54:14 PDT 2020
efriedma added inline comments.
================
Comment at: llvm/lib/CodeGen/ScalarizeMaskedMemIntrin.cpp:894
+ // would be required for scalarizing scalable vectors.
+ if (isa<ScalableVectorType>(LoadTy))
+ return false;
----------------
sdesmalen wrote:
> Should this check be hoisted out of the switch statement and have it return false if the result or any of the operands to the intrinsic is scalable? The intrinsic itself doesn't really matter, given that the pass doesn't produce loops for any of the loads/stores of scalable vector types, not just gather/scatter.
I doubt anyone is going to care about scalable masked_expandloads anytime soon, but sure, hosting it out makes sense.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86249/new/
https://reviews.llvm.org/D86249
More information about the llvm-commits
mailing list