[PATCH] D86673: [StackColoring] Conservatively merge &&Variable for catch(Variable)

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 27 03:50:59 PDT 2020


efriedma added a comment.

> I think there isn't problem of llvm.lifetime.start/end, please see the test in the patch, line 240, 241, 250, 276 all marked with lifetime.start/end.

Those markings aren't really complete.  In particular, if the call throws an exception, the LIFETIME_END of the allocation %stack.1.ex2 never runs.  So it's not clear when the lifetime is supposed to end.


Repository:
  rZORG LLVM Github Zorg

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86673/new/

https://reviews.llvm.org/D86673



More information about the llvm-commits mailing list