[PATCH] D86669: [ValueTracking] Remove MaxLookup from getUnderlyingObjects

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added a comment.

In D86669#2241103 <https://reviews.llvm.org/D86669#2241103>, @lebedev.ri wrote:

>> so there is no reason to limit some sequences by MaxLookup.
>
> Except avoiding runaway compile time in some degenerate cases possibly?

With the current approach it's easy to make similar degenerate case with selects or phi nodes.
It was O(N) and still O(N) of number instructions.
MaxLookup makes getUnderlyingObject O(1), but it does not make getUnderlyingObjects.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86669/new/

https://reviews.llvm.org/D86669