[PATCH] D86575: [lld-macho] Emit binding opcodes for defined symbols that override weak dysyms

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/MachO/SymbolTable.cpp:85
+    if (auto *defined = dyn_cast<Defined>(s))
+      if (!defined->isWeakDef())
+        defined->overridesWeakDef = true;
----------------
smeenai wrote:
> Doesn't this need to check `isWeakDef` as well?
oops. added a test...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86575/new/

https://reviews.llvm.org/D86575