[PATCH] D86573: [lld-macho] Implement weak binding for branch relocations

Wed Aug 26 23:37:36 PDT 2020

int3 marked an inline comment as done.
int3 added inline comments.

================
Comment at: lld/test/MachO/weak-binding.s:106

+_weak_external_fn:
+  ret
----------------
int3 wrote:
> smeenai wrote:
> > If I'm understanding the code correctly, a weak non-external function would behave the same as a weak external function (i.e. it would get a weak binding entry), which is different from non-external data. Is that intended, and either way, could you add a test?
> nope... weak non-externals cannot be coalesced at runtime. I'm not sure the weak flag does anything meaningful to internal symbols actually...
> 
> will add the test
oh, yeah, I see what you're saying now -- my code doesn't actually implement that properly 😅

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86573/new/

https://reviews.llvm.org/D86573