[PATCH] D86528: [4/5] [MC] [Win64EH] Fill in FuncletOrFuncEnd if missing

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 26 22:59:34 PDT 2020


mstorsjo added inline comments.


================
Comment at: llvm/lib/MC/MCWin64EH.cpp:702
+  if (!info->FuncletOrFuncEnd &&
+      Streamer.getCurrentSectionOnly() == info->TextSection)
+    info->FuncletOrFuncEnd = Streamer.emitCFILabel();
----------------
efriedma wrote:
> Instead of checking `Streamer.getCurrentSectionOnly() == info->TextSection`, can we just `Streamer.SwitchSection(info->TextSection)`?
Oh, yeah I guess that'd work just as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86528/new/

https://reviews.llvm.org/D86528



More information about the llvm-commits mailing list