[PATCH] D86574: [lld-macho] Emit the right header flags for weak bindings/symbols

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/MachO/SyntheticSections.cpp:429
       trieBuilder.addSymbol(*defined);
+      hasWeakSymbol |= sym->isWeakDef();
+    }
----------------
This is ridiculously nitty on my part, but if you write this instead, it'll get short-circuited.


================
Comment at: lld/test/MachO/weak-header-flags.s:16
+# WEAK-BINDS-ONLY:        MH_BINDS_TO_WEAK
+# WEAK-BINDS-ONLY-NOT:    MH_WEAK_DEFINES
+
----------------
Nit: I'd prefer an `--implicit-check-not MH_WEAK_DEFINES` in the FileCheck command instead, to catch it both before or after the `MH_BINDS_TO_WEAK` (or you could also add the `NOT` check before as well). I recognize that readobj will probably print them in the order you're checking (and the above test would fail if that order changed anyway), so this is a purely hypothetical concern :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86574/new/

https://reviews.llvm.org/D86574