[PATCH] D86665: [GlobalISel][IRTranslator] Generate better conditional branch lowering.

[Amara Emerson via Phabricator via llvm-commits]

aemerson added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp:396
+
+static bool isValInBlock(const Value *V, const BasicBlock *BB) {
+  if (const Instruction *I = dyn_cast<Instruction>(V))
----------------
I don't think this is strictly necessary for GlobalISel because we don't have to care about values being exported across basic blocks. However, I'd like to port over the functionality as is for now, and then remove it later after doing some performance tests to check the impact.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86665/new/

https://reviews.llvm.org/D86665