[PATCH] D86181: [lld-macho] Implement -ObjC

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/MachO/Driver.cpp:264
+
     inputFiles.push_back(make<ArchiveFile>(std::move(file)));
     break;
----------------
smeenai wrote:
> So we'd be adding ObjC-containing members twice, once as an ObjFile above and once as part of this archive? I don't think it'll cause any issues in practice, but it feels a little ugly conceptually. I think this is fine for now, but long-term it'd be nice to have something like LazyObjFile (like COFF and ELF do) to add each member only once (as either an ObjFile or a LazyObjFile). That would also address the TODO above and my previous comment.
yeah, that's true. I'll expand the TODO comment above to mention this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86181/new/

https://reviews.llvm.org/D86181