[PATCH] D85592: [Attributor] Add flag for undef value to the state of AAPotentialValues

Wed Aug 26 15:05:00 PDT 2020

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM.

In D85592#2240079 <https://reviews.llvm.org/D85592#2240079>, @okura wrote:

> I'm sorry, I don't understand what you expect. The following is my understanding. Could you point out where I'm wrong?
>
> 1. I don't understand the essential difference between the two `bar` functions. I think the potential values of `x1` are `{0,1}`, and the returned value can be simplified to `false` in both cases.
> 2. As for `foo`, we cannot simplify the returned value because the potential value set of `z3` is `{0,1,7}`. I'm not sure how we can take advantage of undef in these examples.

I think you are correct. The examples do not show what I want (we should add them anyway).

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85592/new/

https://reviews.llvm.org/D85592