[PATCH] D86490: [CSSPGO] IR instrinsic for pseudo-probe block instrumentation

[Wei Mi via Phabricator via llvm-commits]

wmi added a comment.

Thanks for splitting the patch into smaller ones. Can you have a separate test just to check the pseudo probe can be parsed and not deleted by any pass?



================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:1986
+    if (CurI.mayHaveSideEffects() && !isa<StoreInst>(CurI) &&
+        !isa<PseudoProbeInst>(CurI))
       return nullptr;
----------------
Can we check CallBase::onlyAccessesInaccessibleMemory instead of checking PseudoProbeInst here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86490/new/

https://reviews.llvm.org/D86490