[PATCH] D86635: [Attributor] Add getter of abstract attributes for the manifestation stage

Shinji Okumura via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 26 10:50:13 PDT 2020


okura added a comment.

Some AAs use `checkForAll...` in manifest, and `getAAFor` is used in the function.
I think we need to add a new parameter like `bool DuringManifest` to them in a follow-up.



================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:3070
-          *this, IRPosition::callsite_function(*CB), /* TrackDependence */ true,
-          DepClassTy::OPTIONAL);
       bool MayReturn = !NoReturnAA.isAssumedNoReturn();
----------------
Though I'm not sure why we force update and track dependence here, I think we can replace this with a new API.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86635/new/

https://reviews.llvm.org/D86635



More information about the llvm-commits mailing list