[PATCH] D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added inline comments.


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:669-770
+  case llvm::omp::Directive::OMPD_parallel: {
+    std::set<SymbolRef>::iterator itAllocate = allocateObjects_.begin();
+    std::set<SymbolRef>::iterator itPrivate;
+    bool hasPrivate;
+    while (itAllocate != allocateObjects_.end()) {
+      itPrivate = privateDataSharingAttributeObjects_.begin();
+      hasPrivate = false;
----------------
Is the code in each of the above cases the same? Can we avoid the duplication by the following or making the common code a function?

case llvm::omp::Directive::OMPD_parallel:
case llvm::omp::Directive::OMPD_target:
case llvm::omp::Directive::OMPD_task:
case llvm::omp::Directive::OMPD_teams: 
New Code
break;




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86051/new/

https://reviews.llvm.org/D86051