[PATCH] D86564: [Support][Windows] Fix incorrect GetFinalPathNameByHandleW() return value check in realPathFromHandle()

Aleksandr Platonov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 26 09:11:27 PDT 2020


ArcsinX added a comment.

In D86564#2239262 <https://reviews.llvm.org/D86564#2239262>, @amccarth wrote:

> I know it's not part of this patch, but Phabricator is showing a clang-tidy lint error on the inclusion of `<io.h>`.  While Windows does have one of these, it's only a compatibility hack, and it doesn't seem to be needed.  Can you yank that `#include <io.h>` line before submitting?

Done


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86564/new/

https://reviews.llvm.org/D86564



More information about the llvm-commits mailing list