[PATCH] D86595: [PowerPC] Handle STRICT_FSETCC(S) in more cases

[Qiu Chaofan via Phabricator via llvm-commits]

qiucf added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:4176
   unsigned Idx = getCRIdxForSetCC(CC, Inv);
   SDValue CCReg = SelectCC(LHS, RHS, CC, dl);
   SDValue IntCR;
----------------
uweigand wrote:
> This is wrong for strict mode.  You'll need to create a strict version of SELECT_CC here, and this needs to handle the (incoming and outgoing) chain.
I think here the method name is a little bit confusing.. It doesn't create `SELECT_CC`, instead, it selects the `fcmp*` opcode by operand type and predicate, and return a machine node of that.

But yes, the chain needs to be handled here since it's the core FP operation we want.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86595/new/

https://reviews.llvm.org/D86595