[PATCH] D86152: [DwarfDebug] Improve multi-BB single location detection in validThroughout (3/4)

Orlando Cazalet-Hyams via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 26 07:36:06 PDT 2020


Orlando added a comment.

@djtodoro do you have any more thoughts on this patch? Copying part of my inline comment here for any other reviewers:

The previous patch in the series (D86151 <https://reviews.llvm.org/D86151>) introduced the `const InstructionOrdering &Ordering` parameter and used it on line 1590, replacing a scan through `MBB` instructions. The functionality to compare instruction positions across blocks was add there, and this patch just removes the exit checks that were previously (but no longer) required.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86152/new/

https://reviews.llvm.org/D86152



More information about the llvm-commits mailing list