[PATCH] D86607: [RDA] Don't visit the BB of the instruction in getUniqueReachingMIDef
Sam Tebbs via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 26 03:51:42 PDT 2020
samtebbs added a comment.
In D86607#2238421 <https://reviews.llvm.org/D86607#2238421>, @SjoerdMeijer wrote:
> I was just writing that I understood that creating a test for this one was very difficult? I.e., creating a small test case, was that this case? Looks like Sam has one now......should it not be part of this change? But anyway, it's fine I guess.
Yeah creating a small test case for this was difficult. I believe that Sam Parker's test depends on both his changes and mine, so would be a chicken and egg problem if we were to include that into this patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86607/new/
https://reviews.llvm.org/D86607
More information about the llvm-commits
mailing list