[PATCH] D86350: [llvm-readobj][test] - Test all possible "Format" values.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 26 02:59:57 PDT 2020


jhenderson added a comment.

This is essentially testing the `getFileFormatName` function in ELFObjectFile.h, which is part of the Object library, not part of llvm-readobj. I'm not sure exhaustively testing all the possible values should be done in an llvm-readobj test. There should be an llvm-readobj test that shows that the Format is printed for one or two given values, but the `getFileFormatName` function should be tested in Object tests (probably best in gtest unit tests), in my opinion.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86350/new/

https://reviews.llvm.org/D86350



More information about the llvm-commits mailing list