[PATCH] D86449: [SelectionDAG] Handle non-power-of-2 bitwidths in expandROT

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/test/CodeGen/WebAssembly/fshl.ll:4
+
+target triple = "wasm32-unknown-unknown"
+
----------------
spatel wrote:
> foad wrote:
> > RKSimon wrote:
> > > move the triple into the run command?
> > Could do but why? That is definitely not the prevailing style in test/CodeGen/WebAssembly/.
> This should be fine. Specifying the target in the IR is the default. 
> Over in x86, we tend to prefer to put it on the RUN line because we have many tests that vary the subtarget slightly...because there are so many HW variations to think about.
Yeah  - don't worry, its just I'm so used to it I think it looks tidier these days.... </OCD>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86449/new/

https://reviews.llvm.org/D86449