[PATCH] D86542: [llvm/Object] - Make dyn_cast<XCOFFObjectFile> work as it should.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 26 02:10:57 PDT 2020
grimar planned changes to this revision.
grimar marked an inline comment as done.
grimar added inline comments.
================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:540
return getCOFFRelocationValueString(COFF, Rel, Result);
+ if (auto *XCOFF = dyn_cast<XCOFFObjectFile>(Obj))
+ return getXCOFFRelocationValueString(XCOFF, Rel, Result);
----------------
MaskRay wrote:
> This reordering is unneeded...
Yes, I've did it to test the change mostly. I'll try to prepare a unit test instead.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86542/new/
https://reviews.llvm.org/D86542
More information about the llvm-commits
mailing list