[PATCH] D86590: [DWARFYAML] Make the unit_length and header_length fields optional.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with nit.



================
Comment at: llvm/lib/ObjectYAML/DWARFEmitter.cpp:526
+    for (uint8_t OpcodeLength : LineTable.StandardOpcodeLengths)
+      writeInteger((uint8_t)OpcodeLength, BufferOS, DI.IsLittleEndian);
+
----------------
No need for the cast, since `OpcodeLength` is `uint8_t`. Does that apply to any of the other `writeInteger` calls elsewhere in this function too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86590/new/

https://reviews.llvm.org/D86590