[PATCH] D86590: [DWARFYAML] Make the unit_length and header_length fields optional.

Wed Aug 26 00:44:10 PDT 2020

jhenderson added inline comments.

================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-line.yaml:489
+#      INFER-LENGTH: Hex dump of section '.debug_line':
+# INFER-LENGTH-NEXT: 0x00000000 39000000 04001b00 00000101 01fb0e0d 9...............
+##                              ^-------                            unit_length (4-byte) 0x39
----------------
jhenderson wrote:
> The unit_length field looks incorrect. It is currently apparently 0x39, yet the end of the things you check is at offset 0x28, so I'd expect a value of 0x24. The header_length looks right though.
Never mind you fixed it whilst I was looking.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86590/new/

https://reviews.llvm.org/D86590