[PATCH] D86442: Skip analysis re-computation when no changes are reported

Tue Aug 25 22:39:10 PDT 2020

serge-sans-paille added a comment.

In D86442#2235449 <https://reviews.llvm.org/D86442#2235449>, @foad wrote:

> Looks good, but do we also need an equivalent of D80916 <https://reviews.llvm.org/D80916> to check that passes are reporting "changed" correctly?

I've got this patch locally, it raises three errors. I'll submit the patch, the passes update once fixed and when everything lands we can finally consider landing this patch :-)

In D86442#2235498 <https://reviews.llvm.org/D86442#2235498>, @nikic wrote:

> Compile-time changes: https://llvm-compile-time-tracker.com/compare.php?from=b9496efbb9ebbf7ec76411fac4e12ff0dc7a8e06&to=4ef4b3b3cc00344aa6e3ff8691e484f1ef7bafba&stat=instructions There is a positive impact, but it's very small. No text size changes.

Thanks for the positive feedback!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86442/new/

https://reviews.llvm.org/D86442