[PATCH] D86587: wq[WIP][Attributor] Per function iteration and memory tracking.

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

> I am looking for feedback on this, there is something that I am missing.

Please describe the approach in the commit message with sufficient detail so one does not need to reconstruct what is going on from the code.



================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:147
 ChangeStatus operator&(ChangeStatus l, ChangeStatus r);
+void operator&=(ChangeStatus &l, ChangeStatus r);
 
----------------
Unrelated.


================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:164
+  /// The bit encodes if it is optional.
+  SmallVector<DepTy, 4> Deps;
 
----------------
Unrelated.


================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:185
   virtual void print(raw_ostream &OS) const { OS << "AADepNode Impl\n"; }
-  TinyPtrVector<DepTy> &getDeps() { return Deps; }
+  SmallVector<DepTy, 4> &getDeps() { return Deps; }
 
----------------
Unrelated.


================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:365
+    return isFnInterfaceKind() || isAnyCallSitePosition();
+  }
+
----------------
Documentation.


================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:964
+    return result;
+  }
+
----------------
Documentation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86587/new/

https://reviews.llvm.org/D86587