[PATCH] D84265: [AIX][XCOFF] emit symbol visibility for xcoff object file.

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:570
+  // table entries for a detailed description. Since we support visibility, and
+  // all other bits are either optionally set or reserved, we only set bits 0-3
+  // for symbol's visibility and leave other bits to zero.
----------------
This should be expressed as the "four most significant bits" instead of "bits 0-3" to avoid confusion in terms of bit numbering convention.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:606
+  // table entries for a detailed description. Since we support visibility, and
+  // all other bits are either optionally set or reserved, we only set bits 0-3
+  // for symbol's visibility and leave other bits to zero.
----------------
Same comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84265/new/

https://reviews.llvm.org/D84265