[PATCH] D86428: [X86] Remove extra getOperand(0) call from recently introduced store(extract_element(vtrunc)) to truncated store combine.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 25 16:02:22 PDT 2020


craig.topper added inline comments.


================
Comment at: llvm/test/CodeGen/X86/oss-fuzz-25184.ll:14-16
+  %E1 = extractelement <4 x double> %tmp5, i16 undef
+  %I2 = insertelement <2 x double> %ret, double 4.940660e-324, i16 undef
+  store double %E1, double* undef, align 8
----------------
spatel wrote:
> Might want to avoid the undefs here to make the test less fragile. These reducer tests tends to wiggle when we improve undef handling.
Unfortunately, the undefs seem to be necessary to get into the scenario that triggered the assert that caught the issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86428/new/

https://reviews.llvm.org/D86428



More information about the llvm-commits mailing list