[PATCH] D86510: [compiler-rt] Fix atomic support functions on 32-bit architectures

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 25 16:00:46 PDT 2020


efriedma added a comment.

> This problem was found while compiling atomic.c for MIPS32 since the -Watomic-alignment warning was being triggered and objdump showed an undefined reference to _atomic_is_lock_free.

Are you sure this fixes the issue properly?  If we're triggering -Watomic-alignment, probably the types are wrong somewhere.  (In particular, some targets support lock-free operations on `_Atomic long long`, but the ABI alignment of `long long` is lower than 8.)

------

Have you seen https://reviews.llvm.org/D45321 ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86510/new/

https://reviews.llvm.org/D86510



More information about the llvm-commits mailing list