[PATCH] D86360: Add new hidden option -print-changed which only reports changes to IR

[Jamie Schmeiser via Phabricator via llvm-commits]

jamieschmeiser added inline comments.


================
Comment at: llvm/test/Other/change-printer.ll:16
+; are checked.
+; N.B. As passes change functionality, this test may fail because it reports
+; whether a pass made a change or not, which can change as pass functionality
----------------
jamieschmeiser wrote:
> ychen wrote:
> > It has some non-trivial maintenance costs. I would suggest to use unit test for this patch altogether.
> I'm sorry but I do not understand what you mean.
> I tried to choose 2 passes that currently and would likely continue to make changes to the source in the test and the tests only check that changes are made and not what the changes actually are, to avoid churn.  I think the only way to completely avoid the possibility of churn would be to not test it.
I now know what you mean and will look into the possibility.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86360/new/

https://reviews.llvm.org/D86360