[PATCH] D85547: [Attributor] Provide an edge-based interface in AAIsDead

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM, one nit



================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:3348
+        AssumedLiveEdges.insert(
+            std::make_pair(I->getParent(), AliveSuccessor->getParent()));
       if (!I->isTerminator()) {
----------------
Move this into the else case below. Only if I is a terminator we need to do this and then we know it is an edge. This actually doesn't catch self loops, so move the insert into the else and remove the condition.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85547/new/

https://reviews.llvm.org/D85547