[PATCH] D86565: [Attributor][FIX] Do not deduce noundef for dead positions

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM, one minor note. The test will be part of the module slice patch, I'm fairly certain this cannot be tested right now but it makes sense.



================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:7752
+    if (A.isAssumedDead(getIRPosition(), nullptr, nullptr,
+                        /* CheckBBLivenessOnly */ true))
+      return ChangeStatus::UNCHANGED;
----------------
I'm not sure this should not be a `false`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86565/new/

https://reviews.llvm.org/D86565