[PATCH] D86489: [PowerPC] Add addtional test that retroactively catches PR47259

Brandon Bergren via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 25 12:09:52 PDT 2020


Bdragon28 added inline comments.


================
Comment at: llvm/test/MC/PowerPC/ppc64-encoding-ext.s:3611
+# CHECK-LE: mtspr 274, 2                    # encoding: [0xa6,0x43,0x52,0x7c]
+            mtsprg 2, 2
+
----------------
ZhangKang wrote:
> I think it's better to use `mtsprg 2, %r2`。
*normally* I would agree here, but the whole point of the test is to catch a screwed up interpretation of instruction alias matching, so making it as vauge as possible is part of the point of the test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86489/new/

https://reviews.llvm.org/D86489



More information about the llvm-commits mailing list