[PATCH] D86549: [MLInliner] Simplify TFUTILS_SUPPORTED_TYPES

[Yundi Qian via Phabricator via llvm-commits]

yundiqian accepted this revision.
yundiqian added a comment.

Yes, Mircea and I discussed about it. Doing conversion in either place is fine. The argument of doing the it here is better isolation of TF and LLVM and easier testing in LLVM

In D86549#2236733 <https://reviews.llvm.org/D86549#2236733>, @ebrevdo wrote:

> This TypeSpec will no longer match specs generated by stringifying tensorflow types.  For example.
>
>   In [4]: tf.int64.name 
>   Out[4]: 'int64'
>
> meaning we will have to do the string conversion in python instead of in C++; either way we can't really get away from it.  Your choice where you want us to do it.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86549/new/

https://reviews.llvm.org/D86549