[PATCH] D86477: [ValueTracking] Let getGuaranteedNonPoisonOp find multiple non-poison operands

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM.

> Instead of special-casing llvm.assume, I think it is also a viable option to add noundef to Intrinsics.td. If it makes sense, I'll make a patch for that.

I think that makes sense.



================
Comment at: llvm/include/llvm/Analysis/ValueTracking.h:590
+  void getGuaranteedNonPoisonOps(const Instruction *I,
+                                 SmallPtrSet<const Value *, 4> &Ops);
 
----------------
Nit: `SmallPtrSetImpl`


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:5111
+      }
+      break;
+    }
----------------
The function pointer too, but unclear if that helps much ;)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86477/new/

https://reviews.llvm.org/D86477