[PATCH] D85782: [X86][ELF] Prefer lowering MC_GlobalAddress operands to .Lfoo$local only for STV_DEFAULT globals

Tue Aug 25 08:48:30 PDT 2020

bd1976llvm added a comment.

In D85782#2235567 <https://reviews.llvm.org/D85782#2235567>, @skan wrote:

> I think this introduces an old issue when lowering the instruction.

Thanks for reporting this. I will need to refresh my understanding on this. Use of protected visibility is rare. The gcc bug is unclear... reading though it they haven't come up with a decision as to what behaviour they want yet. As things stand we now seem to match the current gcc behaviour. We could go back to the original behaviour or we could emit a R_X86_64_PLT32 rather than R_X86_64_PC32 (which is probably the more "correct" ELF thing to do). @MaskRay?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85782/new/

https://reviews.llvm.org/D85782