[PATCH] D77152: [SelectionDAG] Better legalization for FSHL and FSHR

Mon Aug 24 10:51:27 PDT 2020

craig.topper added a comment.

In D77152#2234002 <https://reviews.llvm.org/D77152#2234002>, @foad wrote:

> In D77152#2233991 <https://reviews.llvm.org/D77152#2233991>, @craig.topper wrote:
>
>> In D77152#2233877 <https://reviews.llvm.org/D77152#2233877>, @dmajor wrote:
>>
>>> We're seeing a break in the Firefox build after this change:
>>>
>>>   WidenVectorResult #0: t29: v2i32 = rotl t25, t28, /builds/worker/checkouts/gecko/gfx/angle/checkout/src/image_util/loadimage.cpp:640
>>>   
>>>   Do not know how to widen the result of this operator!
>>>
>>> The reproducers are available from the upper-left pane of https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313707074&repo=try&lineNumber=14721 if you click "Show Job Info".
>>>
>>> Will this be covered by one of the existing followups?
>>
>> We're also seeing this in our internal testing. I was about to put together a patch for it if its not already being worked on.
>
> I'm not working on it yet as I don't have a small test case yet. I imagine the fix is just to add cases for ROTL and ROTR at LegalizeVectorTypes.cpp:2866.

Should be fixed after 43465a43755498e11b14ceb46e278bd127b3b3d7 <https://reviews.llvm.org/rG43465a43755498e11b14ceb46e278bd127b3b3d7>

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77152/new/

https://reviews.llvm.org/D77152