[PATCH] D86536: [obj2yaml] - Cleanup error reporting (remove Error.cpp/.h files)

Xing GUO via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 25 06:41:52 PDT 2020


Higuoxing accepted this revision.
Higuoxing added a comment.
This revision is now accepted and ready to land.

Great, LGTM!



================
Comment at: llvm/tools/obj2yaml/macho2yaml.cpp:648
 
-  return errorCodeToError(obj2yaml_error::unsupported_obj_file_format);
+  llvm_unreachable("unexpected MachO file format");
 }
----------------
I think it should be `Mach-O`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86536/new/

https://reviews.llvm.org/D86536



More information about the llvm-commits mailing list