[PATCH] D86263: [ELF] Keep st_type for symbol assignment

Tue Aug 25 05:47:03 PDT 2020

hans added a comment.

In D86263#2234411 <https://reviews.llvm.org/D86263#2234411>, @MaskRay wrote:

> In D86263#2234268 <https://reviews.llvm.org/D86263#2234268>, @hans wrote:
>
>>> The risk is tiny and can make some users happy. I am in favor of patching this into 11.0.
>>
>> Sounds like a good trade-off :-)
>>
>> I tried applying it, but ELF/arm-thumb-interwork-ifunc.s doesn't pass with it on the branch. I guess the expectations need rebasing. Would you be willing to do that and push it to the branch?
>
> Done in d6d03d09e3f7498f60e2976b8cea235080f55fe7 <https://reviews.llvm.org/rGd6d03d09e3f7498f60e2976b8cea235080f55fe7> (arm-thumb-interwork-ifunc.s needs a clean-up/fix before this patch) & c4e216711d001316df2313a85c8af73a85d804c0 <https://reviews.llvm.org/rGc4e216711d001316df2313a85c8af73a85d804c0> (rewritten `lld/test/ELF/linkerscript/symbol-assign-type.s` to not depend on 'split-file' (which is not in release/11.x)).

Thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86263/new/

https://reviews.llvm.org/D86263