[PATCH] D86517: [RISC-V] Mark C_MV as a move instruction
Luís Marques via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 25 04:43:51 PDT 2020
luismarques accepted this revision.
luismarques added a comment.
This revision is now accepted and ready to land.
LGTM.
================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoC.td:522
-let hasSideEffects = 0, mayLoad = 0, mayStore = 0 in
def C_MV : RVInst16CR<0b1000, 0b10, (outs GPRNoX0:$rs1), (ins GPRNoX0:$rs2),
----------------
I was wondering if it made sense to have both `isMoveReg` and `isAsCheapAsMove`, since the former should imply the latter. Unfortunately, that doesn't seem to be handled automatically, so I guess we need both.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86517/new/
https://reviews.llvm.org/D86517
More information about the llvm-commits
mailing list