[PATCH] D86498: AMDGPU/GlobalISel: Partially move constant selection to patterns

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

Looks OK to me, but I don't know this stuff well enough to approve it.



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUGISel.td:312-314
+def gi_bitcast_fpimm_to_i32 : GICustomOperandRenderer<"renderBitcastFPImm32">,
   GISDNodeXFormEquiv<bitcast_fpimm_to_i32>;
+def gi_bitcast_fpimm_to_i64 : GICustomOperandRenderer<"renderBitcastFPImm64">,
----------------
Can't you call renderBitcastFPImm directly and avoid the 32/64 wrapper functions?


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.td:760
+}]> {
+  let GISelPredicateCode = [{return true;}];
+}
----------------
Why is this needed? Perhaps add a comment? In other cases where you've done this it's because there's a PredicateCode that might return false, but I don't see that here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86498/new/

https://reviews.llvm.org/D86498