[PATCH] D86078: [AArch64] Improved lowering for saturating float to int.

[Bevin Hansson via Phabricator via llvm-commits]

ebevhan added a reviewer: nikic.
ebevhan added a comment.

In D86078#2233560 <https://reviews.llvm.org/D86078#2233560>, @paulwalker-arm wrote:

> Given you are making use of the fact that AArch64 fp_to_int already does the saturation part, I'm wondering if the different-width saturation can be moved from the input to the output?  Specially I'm thinking this will result in nicer code as the min/max immediate values will be easier to produce in integer form.

Ah, so you mean to emit the select-comparisons as integer comparisons rather than floating point comparisons in the second expansion.

It feels like that would work. @nikic, was there any reason in particular you didn't implement it that way in the original patch or does it sound fine to you?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86078/new/

https://reviews.llvm.org/D86078