[PATCH] D86301: [Verifier] Additional check for get.active.lane.mask

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 25 00:40:36 PDT 2020


samparker added inline comments.


================
Comment at: llvm/test/Verifier/get-active-lane-mask.ll:36
+
+define <4 x i1> @t5(i32 %IV) {
+; CHECK-NOT: get_active_lane_mask
----------------
SjoerdMeijer wrote:
> samparker wrote:
> > I'm not familiar with verifying tests.. but why isn't this checking for the same result as the zero input case? 
> because we're checking `%TC > 0` here, so 0 should throw a verifier message, and all the other values should be accepted.
So.... shouldn't -1 also throw the same error?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86301/new/

https://reviews.llvm.org/D86301



More information about the llvm-commits mailing list