[PATCH] D86462: [llvm-readelf][test] - Refine the sections-ext.test

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/sections-ext.test:6
 
-## Check the two-letter aliases above (--st, --sr, --sd) are equivalent to their
-## full flag names.
+## Test --section-symbols(--st), it displays symbols for each section shown.
+# RUN: llvm-readobj --sections --st %t > %t.readobj-st
----------------



================
Comment at: llvm/test/tools/llvm-readobj/ELF/sections-ext.test:12
 
-# RUN: llvm-readobj -S --st %p/Inputs/trivial.obj.elf-i386 > %t.readobj-st-alias
-# RUN: llvm-readobj -S --section-symbols %p/Inputs/trivial.obj.elf-i386 > %t.readobj-st-no-alias
-# RUN: diff %t.readobj-st-alias %t.readobj-st-no-alias
+## Test --section-relocations(--sr), it displays relocations for each section shown.
+# RUN: llvm-readobj --sections --sr %t > %t.readobj-sr
----------------



================
Comment at: llvm/test/tools/llvm-readobj/ELF/sections-ext.test:18-19
 
-# RUN: llvm-readobj -S --sr %p/Inputs/trivial.obj.elf-i386 > %t.readobj-sr-alias
-# RUN: llvm-readobj -S --section-relocations %p/Inputs/trivial.obj.elf-i386 > %t.readobj-sr-no-alias
-# RUN: diff %t.readobj-sr-alias %t.readobj-sr-no-alias
+## Test --section-data(--sd), it displays section data for each section shown.
+## Test that we don't print section data for SHT_NOBITS sections.
+# RUN: llvm-readobj --sections --sd %t > %t.readobj-sd
----------------



================
Comment at: llvm/test/tools/llvm-readobj/ELF/sections-ext.test:193
+# RUN:   FileCheck %s -DFILE=%t --check-prefix=NO-SECTIONS
+# RUN: llvm-readobj --section-symbols %t | FileCheck %s -DFILE=%t --check-prefix=NO-SECTIONS
+# RUN: llvm-readobj --section-relocations %t | FileCheck %s -DFILE=%t --check-prefix=NO-SECTIONS
----------------
MaskRay wrote:
> Can the three RUN lines be combined into one?
They are combined into one (see the line above). I don't think we need the individual versions personally.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86462/new/

https://reviews.llvm.org/D86462