[PATCH] D86451: [llvm-readelf/obj] - Change the return type of the `createDRI(...)` to `Expected<>`

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM.



================
Comment at: llvm/test/tools/llvm-readobj/ELF/dyn-symbols.test:579
+
+# OFFSET-BROKEN: warning: '[[FILE]]': unable to read dynamic symbols from SHT_DYNSYM section with index 1: offset (0xffffffff) + size (0x20) is greater than the file size (0x148)
+
----------------
Not related to this patch, but the inconsistency of where this warning is reported in comparison to the entsize warning looks weird. Looking at code comments (see line 1942 in ElfDumper.cpp in this diff), in one place we ignore the entsize so that we can dump the symbol table, but then later on, we obviously don't. Something for a follow-up patch probably.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86451/new/

https://reviews.llvm.org/D86451