[PATCH] D85740: Universal MachO: support LLVM IR objects

Adrien Guinet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 25 00:15:18 PDT 2020


aguinet marked an inline comment as done.
aguinet added a comment.

Thanks for the new reviews! Fixed in the incoming diff



================
Comment at: llvm/include/llvm/Object/MachOUniversalWriter.h:19
 #include "llvm/Object/Binary.h"
+#include "llvm/Object/IRObjectFile.h"
 #include "llvm/Object/MachO.h"
----------------
smeenai wrote:
> Nit: how come you're including the header here instead of forward declaring `IRObjectFile`?
Nice catch! Fixed in the new diff


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85740/new/

https://reviews.llvm.org/D85740



More information about the llvm-commits mailing list