[PATCH] D85007: [PowerPC] PPCBoolRetToInt: Skip translation if there is ConstantExpr
Guozhi Wei via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 24 23:12:07 PDT 2020
Carrot added a comment.
I think your test case is a perfect candidate for this optimization. It should not be skipped.
The real problem is in function findAllDefs. It should not find out the operands of Constant and push them into Defs.
Suppose we have following ConstantExpr C0 as a phi operand
C0 = C1 > C2
C0 is i1 type, C1 and C2 can be i64 type. And later we should call function translate on C0 only. Translate the type of C1 and C2 doesn't make sense.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85007/new/
https://reviews.llvm.org/D85007
More information about the llvm-commits
mailing list