[PATCH] D86496: [not][test] Fix disable-symbolization.test when 'printenv' is not available

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 24 18:57:13 PDT 2020


aganea added a comment.

In D86496#2235112 <https://reviews.llvm.org/D86496#2235112>, @MaskRay wrote:

> In D86496#2235103 <https://reviews.llvm.org/D86496#2235103>, @thakis wrote:
>
>> This breaks check-llvm on windows: http://45.33.8.238/win/22625/step_11.txt
>>
>> Please take a look and revert for now if it takes a while to fix.
>
>
>
> In D86496#2235104 <https://reviews.llvm.org/D86496#2235104>, @thakis wrote:
>
>> (I'm guessing it was failing under cmd previously and fails in msys/gig bash now?)
>
> It worked in a GnuWin32 environment previously but a Chromium (which did not install full GnuWin32) bot was unhappy. So I created this patch. Glad that Alexandre will handle it. Thanks!
> Looks like GnuWin32 'env' is not conformant...

It is not, GnuWin32 comes with CoreUtils 5.3 from 2005 I believe.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86496/new/

https://reviews.llvm.org/D86496



More information about the llvm-commits mailing list