[PATCH] D86486: [DSE,MemorySSA] Limit walker steps.

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp:1812
         return None;
+      unsigned StepV = KillingDef->getBlock() == Current->getBlock() ? 1 : 5;
+      if (WalkerStepLimit <= StepV)
----------------
Use cl::opts instead of limit numbers in code (e.g. "SameBlockLimit")


================
Comment at: llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp:1825
+      DomAccess = MSSA.getSkipSelfWalker()->getClobberingMemoryAccess(
+          CurrentUD, DefLoc, ClobberSteps);
       if (MSSA.isLiveOnEntryDef(DomAccess))
----------------
use: /*WalkerUpwardsLimit=*/0
remove ClobberSteps.

Why use 0?


================
Comment at: llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp:2260
 
+    unsigned WalkerStepLimit = 50;
     DSEState::CheckCache Cache;
----------------
Can you make this a cl::opt?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86486/new/

https://reviews.llvm.org/D86486