[PATCH] D86487: [DSE,MemorySSA] Check if DomAccess is valid for elimination first.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/test/Transforms/DeadStoreElimination/MSSA/simple.ll:480
 
 ; TODO
 ; We can remove redundant store, as noalias %p guarantees that the function does
----------------
xbolva00 wrote:
> Remove todo?
Thanks, that looks indeed fixed now :)


================
Comment at: llvm/test/Transforms/DeadStoreElimination/MSSA/simple.ll:645
 ; CHECK-NEXT:    [[P2:%.*]] = bitcast i32* [[P:%.*]] to i8*
-; CHECK-NEXT:    store i32 1, i32* [[P]], align 4
 ; CHECK-NEXT:    call void @unknown_func()
----------------
This change looks wrong, I'll fix that tomorrow.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86487/new/

https://reviews.llvm.org/D86487